Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daisy Patch SM Audio Fix #1780

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Daisy Patch SM Audio Fix #1780

merged 1 commit into from
Aug 4, 2022

Conversation

beserge
Copy link
Contributor

@beserge beserge commented Aug 3, 2022 •
edited
Loading

Uncomment PB_11 from the I2C_SDA PinMap. This fixes broken audio on the Daisy Patch SM.

@beserge beserge mentioned this pull request Aug 3, 2022
Merged
ABOSTM
ABOSTM reviewed Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message:

Uncomment PB_11 ...

Otherwise LGTM

@beserge
Daisy Patch SM Audio Fix
19a91e5 
Uncomment PB_11 from the I2C_SDA PinMap
@beserge beserge force-pushed the daisy_patch_sm_audio_fix branch from 25e6fdd to 19a91e5 Compare August 4, 2022 12:13
@beserge
Copy link
Contributor Author

beserge commented Aug 4, 2022

@ABOSTM Fixed, thank you!

@fpistm fpistm merged commit 78cd148 into stm32duino:main Aug 4, 2022
@fpistm fpistm mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beserge @ABOSTM @fpistm